datanoh / gemp-stccg

Automatically exported from code.google.com/p/gemp-lotr
2 stars 1 forks source link

Clean up Card() function #3

Open datanoh opened 2 months ago

datanoh commented 2 months ago

One line of code in deckBuildingUi.js has a dummy parameter labeled "SHADOW". Previously this parameter pulled a card's "side", which is a card element unique to LotR. Not 100% clear what the impact of this parameter is, but we should be able to either remove it or replace it with a game-neutral dummy parameter.

https://github.com/datanoh/gemp-stccg/blob/d692264e60d9e806a0e196aed3c8afd600894ad3/gemp-module/gemp-stccg-client/src/main/web/js/gemp-022/deckBuildingUi.js#L862

https://github.com/datanoh/gemp-stccg/blob/d692264e60d9e806a0e196aed3c8afd600894ad3/gemp-module/gemp-stccg-client/src/main/web/js/gemp-022/jCards.js#L8-L73