Implement Rebranding - Githubissues

datapartnership / datapartnership.github.io

:pencil: Projects & News

https://datapartnership.org

Other

6 stars 0 forks source link

Implement Rebranding #2

Closed brunosan closed 4 years ago

brunosan commented 4 years ago

I just pushed 27f7cea which updates the name in the code. I don't see it deploying (blocked by #1), but also the email remains the same, as we don't yet have a new email.

Let's update it when it's done, and make sure there are no other leftover branding to fix.

🎉 for the new name! 😄

brunosan commented 4 years ago

Since this code is not the one deployed on datapartnership.org/ (see https://github.com/datapartnership/datapartnership.org/issues/1#issuecomment-567007783) I've reverted it on the main branch, and moved it to a new separate branch rebranding. Once we are clear on #2 we can deploy it properly.

mireille-raad commented 4 years ago

correct, this is not the code on the main site. Holly just added you to the netlify team, so you should be able to see the deployed version there.

I think we need the following branches:

develop: until I finish developing the thing
master: once develop stage is done, we'll move to master
preview: a temp preview branch that I can setup, in case someone wants to preview the content before hitting publish.

mireille-raad commented 4 years ago

I got some feedback from comms colleagues. I will wait for their new content (timeline) and final round of edits to update the site.

feedback-Data_external website.pdf

brunosan commented 4 years ago

[x] I understand netlify is the tool to deploy, and I can follow the steps to deploy it to a random URL netlify give me. I also understand forestry.io is just the UI to edit flat .md files.
[x] @mireille-raad I think the canonical URL https://datapartnership.org/ is attached to a netlify account/team I'm not a member of.
[x] @mireille-raad The master branch of this repo is not the same as the deployed https://datapartnership.org/ . If the deployment happens automatically from the master branch, I do not understand why they are not the same.
[x] We need to implement comms feedback, but we don't yet have all of it (only the comment above).

mireille-raad commented 4 years ago

I think the canonical URL https://datapartnership.org/ is attached to a netlify account/team I'm not a member of.

For the netlify team, holly needs to add you. I'll re-check with her.

The master branch of this repo is not the same as the deployed https://datapartnership.org/ . If the deployment happens automatically from the master branch, I do not understand why they are not the same.

I double checked. Screenshot from 2020-01-21 11-17-32

Screenshot from 2020-01-21 11-17-58

mireille-raad commented 4 years ago

For comms feedback, I need to make sure we have the final design of the image for the timeline. There was some back and forth on it and I wanted to make sure the design is final.

brunosan commented 4 years ago

This is done, closing. Also deleting branch develop has it only behind master without any forward changes.