Holly-Transport
commented
4 years ago Yes - don't be mad at me, but the icons should be aligned with each other, horizontally.
Can you swing that (and I full recognize how hard that is to do in .css)... H
On Sat, Mar 28, 2020 at 1:29 PM Bruno Sánchez-Andrade Nuño < notifications@github.com> wrote:
This PR changes the listicle of "pillars adding new icons"
This is the old listicle: [image: Screen Shot 2020-03-28 at 6 24 58 PM] https://user-images.githubusercontent.com/434029/77829298-79d3bb00-7121-11ea-95ad-a223e204e7e3.png and this is the new listicle [image: Screen Shot 2020-03-28 at 6 25 07 PM] https://user-images.githubusercontent.com/434029/77829306-81935f80-7121-11ea-877f-8266b89241ef.png
which is the same as the design specs I got: [image: Screen Shot 2020-03-28 at 6 25 52 PM] https://user-images.githubusercontent.com/434029/77829320-94a62f80-7121-11ea-9599-3dd008f822bc.png
Please note that we have 10 icons and we only using 6 [image: Screen Shot 2020-03-28 at 6 27 50 PM] https://user-images.githubusercontent.com/434029/77829362-da62f800-7121-11ea-9282-6746dbedfab9.png
@Holly-Transport https://github.com/Holly-Transport, are you happy with it? Merge?
You can view, comment on, or merge this pull request online at:
https://github.com/datapartnership/datapartnership.org/pull/22 Commit Summary
- Add icon assets
- Add logo field to pillars
- chage order to match mockup
- Replace text listicle with image-card listicle
File Changes
- M content/pillars/access.md https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-f426cc894d906ca7c40c20c27e60a732 (6)
- M content/pillars/data-partnership-management.md https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-6725ee9f0ed2ee14fb9e6175aab156a7 (6)
- M content/pillars/derived-data-products.md https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-b5681d5bb6f33f634e1b7728ef3adcbf (6)
- M content/pillars/it-architecture.md https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-dddd47a90e58a2d223cdcdc9399fa344 (4)
- M content/pillars/legal.md https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-54198ccf544bb590b6c9b060aedda84c (6)
- M content/pillars/multi-disciplinary-teams.md https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-1e625d6654474ea1e0cda613f65c7579 (4)
- A static/icons/comms.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-0e13dd43f03b14d6efd1eac56c9b5150 (0)
- A static/icons/data-use.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-771ac9fcef299a1e983731b5bc2bb2c4 (0)
- A static/icons/engineering.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-30fe5282bb69897724737653b1ffe766 (0)
- A static/icons/goods.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-ff9d195e3cc7ba98a1a9dba36258fdf1 (0)
- A static/icons/legal.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-23e107815ed42c1de89913f90b449873 (0)
- A static/icons/legal2.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-43bed9394c67650eb31dbd3bc1c85d4d (0)
- A static/icons/management.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-c5cb5e27de08e8f202ca09820bd4d35c (0)
- A static/icons/secretariat.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-e5700f2dc261c98cff661b967ff21e0c (0)
- A static/icons/secure.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-efcd234a61125ad998b6f2e4cabb1e1a (0)
- A static/icons/teams.png https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-b13a6fbc4dfbaa78776e255d07cb1ed0 (0)
- M themes/dp-imf-theme/layouts/partials/pillars.html https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-65f1ecc4e004e897cde4ddd8ffc4142c (18)
- M themes/dp-imf-theme/static/css/main.css https://github.com/datapartnership/datapartnership.org/pull/22/files#diff-411cad109c134dd3ad3f4dc1b2b6c722 (6)
Patch Links:
- https://github.com/datapartnership/datapartnership.org/pull/22.patch
- https://github.com/datapartnership/datapartnership.org/pull/22.diff
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datapartnership/datapartnership.org/pull/22, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCI5PXV2YIM4DLY7ZXJMCTRJYXX3ANCNFSM4LVUWT4Q .
This PR changes the listicle of "pillars adding new icons"
This is the old listicle:
and this is the new listicle
which is the same as the design specs I got:
Please note that we have 10 icons and we only using 6
@Holly-Transport, are you happy with it? Merge?