datapartnership / red-sea-monitoring

Data and analytics to support monitoring of changes in Red Sea maritime traffic
http://datapartnership.org/red-sea-monitoring/
Mozilla Public License 2.0
0 stars 0 forks source link

Review of the "Global Port Spillover Estimator" code #13

Closed yahui-zhao closed 6 months ago

yahui-zhao commented 7 months ago

Many thanks for the great work! Here are some suggestions.

For Part I: "Estimating At-Risk Capacity of a Port Disruption (Metric Tons) by Country," the code is very clear and well-written, with no issues in the results.

For Part II: "Estimating Aggregated At-Risk Export Value by Country from Any Port Disruption in a Selected Country (USD)," it is suggested only to select rows where "industry" equals "Total" when filtering data. This is to avoid the issue of double counting. Due to this oversight, the correct results should be exactly half of the current findings.

Thank you again!

Holly-Transport commented 6 months ago

Resolved - thank you.