datapartyjs / dataparty-crypto

It slices, it dices, and it enciphers
http://dataparty.xyz
Apache License 2.0
4 stars 0 forks source link

BUG | No hard coded salt in examples #18

Closed sevenbitbyte closed 1 year ago

sevenbitbyte commented 1 year ago

🐛 Bug Report

A redditor made a great point about examples with hard coded salt. People will just copy-pasta them... and rainbow table is your uncle :(

Screenshot_2023-04-22_22-03-24

https://www.reddit.com/r/javascript/comments/12vtsvr/comment/jhcv835/?utm_source=reddit&utm_medium=web2x&context=3

Changes needed

sevenbitbyte commented 1 year ago

Reviewed @dataparty/api, which has no hard coded salt.

sevenbitbyte commented 1 year ago

https://github.com/datapartyjs/dataparty-crypto/commit/3a7a48a91937a8301e53609dff608a849a81c0b0