search

dataplat / Invoke-SqlCmd2

PowerShell module containing Invoke-SqlCmd2
MIT License
68 stars 35 forks source link

ApplicationName parameter #15

Closed testtwice closed 4 years ago

testtwice commented 6 years ago

lines 386-389 have 

if ($ApplicationName) {
    $CSBuilder["Application Name"] = $ApplicationName
}

but I don't see a parameter defined for $ApplicationName.

Should there be one like this?:

[Parameter(Position = 11,
    Mandatory = $false,
    ValueFromPipelineByPropertyName = $true,
    ValueFromRemainingArguments = $false)]
[string]$ApplicationName
alevyinroc commented 6 years ago

Using the ConnectionStringBuilder was a change I started almost a year ago and things got muddy when I attempted to merge/PR my changes several months after I made the changes. I'll check into this, I probably missed something in copying my changes over.

alevyinroc commented 6 years ago

@potatoqualitee or @RamblingCookieMonster can you please assign this to me?