search

dataplat / Invoke-SqlCmd2

PowerShell module containing Invoke-SqlCmd2
MIT License
68 stars 35 forks source link

Fix to allow -As PSObject to work with PSCore #21

Closed jeremymcgee73 closed 5 years ago

jeremymcgee73 commented 6 years ago

This update allows -as PSObject to work in PScore. There was an error that the object type were missing. I used the code from the following PowerShell issue as an example to fix it. I tested this in PowerShell 5.1 and 6.04 on both Windows and Ubuntu. Let me know if you have any questions!

potatoqualitee commented 5 years ago

hey jeremy - sorry for the late response, I don't appear to follow this repo. The code looks reasonable to me, though I haven't tested it. @niphlod would you be able to take a look?

niphlod commented 5 years ago

yup

niphlod commented 5 years ago

LGTM. Who merges ? (when it's merged I'll backport to dbatools's Invoke-DbaQuery too)

niphlod commented 5 years ago

shootout to @potatoqualitee to keep things "official" and in the "MVP" area for trusted mergers :-P

potatoqualitee commented 5 years ago

You're our MVP, @niphlod ! All merges by you are trusted.

jeremymcgee73 commented 5 years ago

Thank you all! Can we get the latest version in the gallery? @potatoqualitee Thanks again!