dataplat / dbachecks

✔ SQL Server Environmental Validation
https://dbachecks.readthedocs.io/en/latest/
MIT License
460 stars 141 forks source link

unit tests and correct variable - fixes #912 #929

Closed SQLDBAWithABeard closed 1 year ago

SQLDBAWithABeard commented 1 year ago

A New PR

THANK YOU - We love to get PR's and really appreciate your time and help to improve this module

Accepting a PR

Before we accept the PR - please confirm that you have run the tests locally to avoid our automated build and release process failing. You can see how to do that in our wiki

https://github.com/sqlcollaborative/dbachecks/wiki

Please confirm you have 0 failing Pester Tests

[X] There are 0 failing Pester tests

Changes this PR brings

Fixes this strange bug, no idea when it came in because I rearranged all of the files and that blows the history away.

Unit Tests added back in as well Please add below the changes that this PR covers. It doesnt need an essay just the bullet points :-)

github-actions[bot] commented 1 year ago

Linux Test Results

       1 files  ±0     551 suites  +1   37s :stopwatch: -2s 1 721 tests +4  1 721 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0  2 099 runs  +4  2 099 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0 

Results for commit d6f5ef68. ± Comparison against base commit 277886e4.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

WinPS51 Test Results

       1 files  ±0     551 suites  +1   31s :stopwatch: +6s 1 721 tests +4  1 721 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0  2 099 runs  +4  2 099 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0 

Results for commit d6f5ef68. ± Comparison against base commit 277886e4.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

WinPS71 Test Results

       1 files  ±0     551 suites  +1   26s :stopwatch: -2s 1 721 tests +4  1 721 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0  2 099 runs  +4  2 099 :heavy_check_mark: +4  0 :zzz: ±0  0 :x: ±0 

Results for commit d6f5ef68. ± Comparison against base commit 277886e4.

:recycle: This comment has been updated with latest results.