search

dataplat / dbatools

🚀 SQL Server automation and instance migrations have never been safer, faster or freer
https://dbatools.io
MIT License
2.44k stars 796 forks source link

Update logging framework based on new version of PSFramework #8392

Open andreasjordan opened 2 years ago

andreasjordan commented 2 years ago

Summarize Functionality

See: https://twitter.com/FredWeinmann/status/1533198245496758274

Yo fellows, the latest version of the #psframework #powershell module shipped today! Massively improved logging performance for the logfile provider (and no more collision with your AV), new command to clear in-memory log and (thanks @adamdriscoll !) fixed a memory leak.

Is there a command that is similiar or close to what you are looking for?

No

Technical Details

No response

adamdriscoll commented 2 years ago

@FriedrichWeinmann probably has a good idea on this but from what I can tell, it looks like dbatools doesn't have the same problem that PSFramework had in terms of the memory leak. I can't speak to the logging performance.

FriedrichWeinmann commented 2 years ago

Indeed, for dbatools, this is not a memory leak issue, however the throughput improvements remain real

andreasjordan commented 1 year ago

Do you have time to work on this?

wsmelton commented 1 year ago

What needs to be fixed? We have no memory leak on our logging mechanism.

The logging system we have is the beginnings of what PSFramework became and at this point we are so far behind where that module has gone it is unrealistic to think Fred will have time for porting that over. It would be more efficient to swap our logging to depend on PSFramework...but that is not something I would agree with incorporating in the module.

In the area of performance if you want the module to perform better the best option is disabling our logging system itself. You should do that for any automation process, logging is for when you are debugging or troubleshooting.

andreasjordan commented 1 year ago

Thanks for the feedback, will close this now.

potatoqualitee commented 1 year ago

I think it's a fair question to ask if the fix is quick. Any perf improvements are welcomed

FriedrichWeinmann commented 1 year ago

I've added it for my vacation coding list (calendar blocker and everything so I don't forget; August). Will do the upgrade - the overall effort should be doable.

andreasjordan commented 6 months ago

Hi @FriedrichWeinmann - is this still on your to do list?