dataplat / dbatools

🚀 SQL Server automation and instance migrations have never been safer, faster or freer
https://dbatools.io
MIT License
2.39k stars 787 forks source link

Update-ServiceStatus - fix cross-domain issue by changing ComputerName to PSComputerName #9288

Closed fuixx217 closed 3 months ago

fuixx217 commented 3 months ago

When running commands from a server connected to domainA to a computer running on domainB, the short name is used as documented on https://github.com/dataplat/dbatools/issues/9184. This is my attempt to get this change moving forward as the issue conversation has been quiet.

Type of Change

Purpose

Approach

Commands to test

Screenshots

Learning

potatoqualitee commented 3 months ago

Thank you! Fix looks interesting. Let's see if we can get these tests to pass. hopefully it was an issue with the runner and not the change.

potatoqualitee commented 3 months ago

This fix seems reasonable. Thank you for your patience.