[x] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
[ ] Unit test is included
[ ] Documentation
[ ] Build system
Purpose
Fix an issue where the command didn't work properly if you had a variable in your session called $SqlLogins
Approach
Remove deprecated code - this used to be needed, but after the parameters were renamed it no longer is.
Commands to test
# this should work
Get-DbaLogin -SqlInstance $source |ft
# then set a variable and rerun - it'll only show sql logins - after this PR this works
$sqllogins = @(
"myDomain\UserA",
"myDomain\UserA")
Get-DbaLogin -SqlInstance $source |ft
Screenshots
Before - shows issue - second screenshot there are now Windows* logins
Type of Change
.\tests\manual.pester.ps1
)Purpose
Fix an issue where the command didn't work properly if you had a variable in your session called
$SqlLogins
Approach
Remove deprecated code - this used to be needed, but after the parameters were renamed it no longer is.
Commands to test
Screenshots
Before - shows issue - second screenshot there are now Windows* logins![image](https://github.com/dataplat/dbatools/assets/981370/dbc47110-04cf-4085-bff0-81abe8590d4f)
After - variable doesn't change results![image](https://github.com/dataplat/dbatools/assets/981370/fb368c5d-c9b5-48a2-9858-531a1a8cae4a)
tests passing![image](https://github.com/dataplat/dbatools/assets/981370/98f690fa-9d2c-459f-8f75-2ec209710465)