dataplat / dbatools

🚀 SQL Server automation and instance migrations have never been safer, faster or freer
https://dbatools.io
MIT License
2.39k stars 787 forks source link

change splatting to remove <br> from docs #9292

Closed jpomfret closed 3 months ago

jpomfret commented 3 months ago

Type of Change

Purpose

The docs on the website have <br> at the end of each row currently from splatting image

@niphlod - is there any other options? or is this the fix? Got this from looking at other commands where it works image

If this is the fix - I have some more to fix before this PR gets merged... so marking as draft for now

niphlod commented 3 months ago

hi @jpomfret , there's a whole logic behind doc generation but can be replicated locally. If you give me a specific page we can see if it's a problem on the "generation" or on the "display" side of things

edit: that being said you got the gist. Right now multiline examples should be prefixed by either PS C:\> or >> . We could change it but it needs proper testing to avoid breaking other pages.

For the curious enough, logic is in here https://github.com/dataplat/docs/blob/master/assets/templates/to_md.ps1, it turns the json help into markdown pages.

jpomfret commented 3 months ago

This is an example: https://docs.dbatools.io/New-DbaReplCreationScriptOptions.

I will check out that logic and test locally, and then upload the rest of the changes here. Thanks!

potatoqualitee commented 3 months ago

MERCi