Update-SqlPermission (used by Copy-DbaLogin) - Fix for using LoginRenameHashtable together with user different to login

andreasjordan commented 3 months ago

Type of Change

[ ] Bug fix (non-breaking change, fixes #9283 )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (affects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
[ ] Unit test is included
[ ] Documentation
[ ] Build system

See issue for details.

This solves the issue, but do we want to leave the user with the old name in the database? Or should the old user be deleted?

potatoqualitee commented 2 months ago

safest way is to leave the old user and give a warning that includes the command to run to delete the user? or opt-in delete user with a switch?

potatoqualitee commented 2 months ago

thank you btw!