New-DbaComputerCertificate - Only use MonthsValid for self-signed certificates

[andreasjordan]

…cate)

Type of Change

• [x] Bug fix (non-breaking change, fixes an issue with pr #9264 )
• [ ] New feature (non-breaking change, adds functionality, fixes # )
• [ ] Breaking change (affects multiple commands or functionality, fixes # )
• [ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
• [ ] Adding code coverage to existing functionality
• [ ] Pester test is included
• [ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
• [ ] Unit test is included
• [ ] Documentation
• [ ] Build system

See comments on #9264 for details.

Summary: NotBefore and NotAfter are only valid for RequestType = Cert, which are the self-signed certificates. They are not valid for the others as they use RequestType = PKCS10. See documentation: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/certreq_1

[potatoqualitee]

thanks, man. i did not know that. looks good.