Add-DbaDbRoleMember - Add support for adding roles to roles

dataplat / dbatools

🚀 SQL Server automation and instance migrations have never been safer, faster or freer

https://dbatools.io

MIT License

2.39k stars 787 forks source link

Add-DbaDbRoleMember - Add support for adding roles to roles #9319

Closed andreasjordan closed 2 months ago

andreasjordan commented 3 months ago

Type of Change

[x] Bug fix (non-breaking change, fixes #9302 )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (affects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
[ ] Unit test is included
[ ] Documentation
[ ] Build system

See issue for details.

andreasjordan commented 3 months ago

We have to change Get-DbaDbRoleMember as well. Will work on this in the next days.

andreasjordan commented 2 months ago

I added them member roles to Get-DbaDbRoleMember in a way that this is a non-breaking change. But I would prefer changing the output in a way that we don't use "user" or "role" but "member". But that would be a breaking change. Maybe planning that for the next major version?

mattcargile commented 2 months ago

The code looks good. Thanks!

Would love to see DbaServerRoleMember cmdlets get the same treatment on the parameters. Might involve more breaking changes.

andreasjordan commented 2 months ago

Let's first have @potatoqualitee have a look at this PR. Then we can talk about breaking changes.

potatoqualitee commented 2 months ago

thank you for the alias! @ClaudioESSilva can you pls take a look and approve?

potatoqualitee commented 2 months ago

oh, good. thanks everyone 😊