Update dbatools-buildref-index.json security patches 2019, 2022

dataplat / dbatools

🚀 SQL Server automation and instance migrations have never been safer, faster or freer

https://dbatools.io

MIT License

2.39k stars 787 forks source link

Update dbatools-buildref-index.json security patches 2019, 2022 #9322

Closed MikeyBronowski closed 2 months ago

MikeyBronowski commented 2 months ago

Type of Change

[ ] Bug fix (non-breaking change, fixes # )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (affects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
[ ] Unit test is included
[x] Documentation
[ ] Build system

Purpose

Security patch for SQL 2019 CU25 Security patch for SQL 2019 RTM Security patch for SQL 2022 CU12 Security patch for SQL 2022 RTM

Approach

Commands to test

Screenshots

Learning

potatoqualitee commented 2 months ago

Thank you both 🙇🏼 will merge shortly

potatoqualitee commented 2 months ago

I'm unsure why the repo size test passed, but @MikeyBronowski -- the current .git repo is 72MB but the repo in this PR is 300+ MB. Can you please delete your dbatools folder, reclone and resubmit PR?

MikeyBronowski commented 2 months ago

I'm unsure why the repo size test passed, but @MikeyBronowski -- the current .git repo is 72MB but the repo in this PR is 300+ MB. Can you please delete your dbatools folder, reclone and resubmit PR?

I made changes through the web interface. Went straight to the file in dataplat repo and it created a branch under my fork.

MikeyBronowski commented 2 months ago

Actually, I did it online, but used that Vs code feature in the browser. I think it was the first time I did it this way so maybe my fork was not up to date.

potatoqualitee commented 2 months ago

ahh yeah, might need to refork?

MikeyBronowski commented 2 months ago

I wonder if that happened before (web interface but no Vs code) as I usually update those ref details this way.

wsmelton commented 2 months ago

@MikeyBronowski using the web UI you can go to your fork and tell it to update it to upstream

MikeyBronowski commented 2 months ago

@MikeyBronowski using the web UI you can go to your fork and tell it to update it to upstream

That's what I did after Chrissy's comment.

Previously I never updated the fork when adding changes through the GitHub web interface, so either this was unnoticed before or change done via web vs code did it differently (that's the first time I used web vs code here.