dataplat / dbatools

🚀 SQL Server automation and instance migrations have never been safer, faster or freer

https://dbatools.io

MIT License

2.39k stars 787 forks source link

New Support for Contained Availability Groups #9345

Closed serenefiresiren closed 1 month ago

serenefiresiren commented 1 month ago

Type of Change

[ ] Bug fix (non-breaking change, fixes # )
[x] New feature (non-breaking change, adds functionality, fixes #8713 )
[ ] Breaking change (affects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
[ ] Unit test is included
[ ] Documentation
[ ] Build system

Purpose

SQL Server 2022 added support for contained availability groups.

Approach

The New-DbaAvailabilityGroup leverages the built-in ReuseSystemDatabses and IsContained parameters to facilitate both the initial build and a recreation with previously provisioned contained databases.

Commands to test

Work in progress

Learning

What is a contained availability group? New-SQLAvailabilityGroup SMOObject

serenefiresiren commented 1 month ago

Thanks for the feedback! I'll get these fixed Monday.

potatoqualitee commented 1 month ago

Thank you both 🙏🏼 Will fix encoding issue once changes are complete, just prior to merge.

DorBreger commented 1 month ago

https://github.com/serenefiresiren/dbatools/pull/2

andreasjordan commented 1 month ago

Sorry, still not correct. Please have a look at the other parameter tests.

andreasjordan commented 1 month ago

9352 has all the needed changes, so we should close this one.

potatoqualitee commented 1 month ago

thank you all 🙏🏼 will merge for credit and fix all issues in next PR