Closed rferraton closed 1 month ago
Why is this needed? I don't see any issue linking the feature being requested. If we are not going to do an issue please expand on the scenarios (multiple are needed) this is meeting to address (these must be what we built tests on for the command).
breaking changes to existing backup scripts
Who's backup scripts?
breaking changes to existing backup scripts
Who's backup scripts?
I mean that the new parameter NoAppendDbNameInPath , is not activate by default. If it was, it would lead to a behavior change and would impact backup directories output (in all currently used backup scripts using Backup-DbaDatabase over the world).
Using such a switch parameter allow to avoid breaking change because it will prevent the dbname to be added at the end of the backup path only when used ==> no breaking change.
I closed the issue https://github.com/dataplat/dbatools/issues/9341 that i opened a couple of days ago to signal a problem when dbname is long because niphlod say that is was more an enhancement request.
So i did the enhancement request #9346, made the enhancement, and push it.
Thank you, @rferraton. This is a nice solution. @niphlod can you give approval? I will merge upon approval from core team.
looks good, may be a niche case, and would probably benefit from a specific test to make sure no regressions are introduced.
merci 🇮🇹 😊
Thanks/Merci !
Type of Change
.\tests\manual.pester.ps1
)Purpose
Approach
Add a new switch variable that will avoid breaking changes to existing backup scripts using Backup-DbaDatabase but will allow to prevent the dbname to be systematicaly added at the end of the path
Commands to test
Screenshots