dataplat / dbatools

🚀 SQL Server automation and instance migrations have never been safer, faster or freer
https://dbatools.io
MIT License
2.39k stars 787 forks source link

New-DbaAvailabilityGroup: Add support for contained availability groups #9352

Closed DorBreger closed 1 month ago

DorBreger commented 1 month ago

Type of Change

Purpose

Support for sql server 2022 availability groups

Approach

Commands to test

Screenshots

Learning

andreasjordan commented 1 month ago

Failed test is:

Describe : dbatools style
Context  : BOM
Name     : It New-DbaAvailabilityGroup.ps1 has no BOM in it
Result   : Failed
Message  : Expected strings to be the same, but they were different.
           Expected length: 4
           Actual length:   7
           Strings differ at index 4.
           Expected: 'utf8'
           But was:  'utf8bom'
           ---------------^
Describe : dbatools style
Context  : formatting
Name     : It New-DbaAvailabilityGroup.ps1 is not compliant with the OTBS formatting style. Please run Invoke-DbatoolsFormatter against the failing file and commit the changes.
Result   : Failed
Message  : Expected 0, but got 1.

@potatoqualitee - please fix this before merging.

andreasjordan commented 1 month ago

Please close #9345 if this PR is merged.

potatoqualitee commented 1 month ago

Fantastic, all tests pass 🚀 Thanks to everyone!