New-DbaAgentSchedule: Fix issues with testing for correct dates and times

[andreasjordan]

Type of Change

• [x] Bug fix (non-breaking change, fixes #9388 )
• [ ] New feature (non-breaking change, adds functionality, fixes # )
• [ ] Breaking change (affects multiple commands or functionality, fixes # )
• [ ] Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
• [ ] Adding code coverage to existing functionality
• [ ] Pester test is included
• [ ] If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
• [ ] Unit test is included
• [ ] Documentation
• [ ] Build system

See issue for details.

We now use the correct types for the SMO properties.

Maybe we should also add two new parameters StartDateTime and EndDateTime with [datetime] datatype as an alternative for the four string parameters. I can do this if other contributors agree.

[andreasjordan]

I don't see why the test fails. The test uses Schedules, but I don't see a relation to the code change. Can someone help?

[potatoqualitee]

i wondered if these were breaking changes. ill take a closer look this weekend 👍🏼

[andreasjordan]

Just found a copy-paste-bug I introduced. Will fix in a minute...

[andreasjordan]

Now all tests pass.

[potatoqualitee]

excellent, thanks andreas!