dataproofer / Dataproofer

A proofreader for your data
http://dataproofer.org/
691 stars 53 forks source link

Use v4 instead of v1 uuids #153

Closed ctavan closed 4 years ago

ctavan commented 5 years ago

Summary

I'm a co-author of the uuid npm module which is being used in some places within this code base.

I'm currently trying to understand real-world use cases of time-based UUIDs ("v1 UUIDs").

Proposed changes

I found two occurrence where v1 UUIDs were being used instead of v4 UUIDs and I was wondering if these cases really require the semantically much more complex v1 UUIDs or whether we could live equally well with purely random v4 UUIDs? Please see my commit messages for more details.

I'd be really curious to understand the motivation for choosing v1 over v4 UUIDs in the first place, so any feedback on this would be highly appreciated!

@enjalot as far as I can tell from the git history (10f9bef1591fd55f4626c1a7ac6492eaa54164f0) it seems like you have introduced the v1 UUIDs so I'd be particularly interested in your feedback.

@dataproofer/core