search

datapythonista / dicom_reader

0 stars 1 forks source link

Use cases #2

Open sparalic opened 1 year ago

sparalic commented 1 year ago

Added changed the pixel_data fn in Rust to work for this dataset. Will need to get a more general case...

datapythonista commented 1 year ago

I merged the other PR, so this is conflicting now, as you continued in the same branch.

To avoid problems I'd recommend always having the master branch clean (with no changes from what's in the main repo master) and work on every feature in a separate branch. Ideally for the previous PR it was better to have separate branches and PRs for the MacOS compat work, and for the use cases notebook. And the change of type here would be in a new different branch.

When you are working in a project by yourself of course it's faster and simpler to work on the master branch directly, but when working with others this helps keep things under control.

sparalic commented 1 year ago

Will do going forward since this is a shared space.