search

datarefuge / workflow

DataRescue activities workflow as developed by the DataRefuge project and EDGI
https://datarefuge.github.io/workflow/
Creative Commons Attribution Share Alike 4.0 International
49 stars 32 forks source link

Issue #93: change references to EOT Harvester in the seeder documentation #94

Closed janetriley closed 7 years ago

janetriley commented 7 years ago

Changed references to End of Term to Internet Archive and updated URL.

janetriley commented 7 years ago

Ping for review: @khdelphine @dcwalk @liblaurie @titaniumbones

dcwalk commented 7 years ago

Also--question... do we want to add an explainer about the change to "saving" vs. "nominating"? (maybe as a note, see below)

<div class = "attention">
  <strong>Note: [Name]</strong> <br />  
  [Text]
</div>
khdelphine commented 7 years ago

The edits look great.

@dcwalk, to me the word "save" seems to imply that the action is instantaneous, which is not the case. Or am I overthinking this?

dcwalk commented 7 years ago

@khdelphine -- we are moving to implement a direct save using the IA's API now that the End of Term crawl is over.

khdelphine commented 7 years ago

@dcwalk Ah ok, I had missed that. Perfect!

dcwalk commented 7 years ago

Once the changes are made, I think we want to hold off/ensure we merge this in at the right time (i.e., in sync with the App update)

janetriley commented 7 years ago

The language is updated.

Re: Explainer note about the change - is anyone outside the project going to notice? It strikes me as one of those changes that's significant when you make the update but you forget two months later.

dcwalk commented 7 years ago

Fair point @janetriley. This looks great! I'm just going to pause a bit on this to ensure we are in sync with the convo in the Chrome Extension repo: https://github.com/edgi-govdata-archiving/eot-nomination-tool/issues/72

Ping me by Friday if I haven't moved on this!

dcwalk commented 7 years ago

Sorry for the delay on this, it took awhile to pin down our process with IA. We are gonna keep using the nominate language, merging in for the weekend :)