search

datarevenue-berlin / OpenMLOps

MIT License
703 stars 101 forks source link

A few questions after following the setup guide #85

Closed offchan42 closed 2 years ago

offchan42 commented 3 years ago

I was following this guide: https://github.com/datarevenue-berlin/OpenMLOps/blob/master/tutorials/set-up-open-source-production-mlops-architecture-aws.md#configuring-the-my_varstfvars-file and have a few questions.

  1. Do I need to set additional_aws_users field in my_vars.tfvars to an empty list if I just have only one user (me)? image

  2. If I am the only user, do I need to fill in oauth2_providers? Or do I just need to make it an empty list? If I need to create a new OAuth application, what should I fill in the Authorization callback URL text box? image

  3. If I set both 2 attributes above to be empty lists and run terraform init, it asks me to enter an S3 bucket name. What should I fill in this? If it's related to the bucket_name field in the my_vars.tfvars file, I've already set it. image

bernardolk commented 2 years ago

Hi there,

  1. No, its not required, it defaults to an empty list.
  2. I believe it should also work without this being set, but could you try https://{your_host}/.ory/kratos/public/self-service/methods/oidc/callback/github ?
  3. Actually, this would be the bucket that Terraform stores its state, which is different than the bucket you specify in my_vars.tfvars. You can configure your Terraform backend to local if you don't wish to use S3 for that.
offchan42 commented 2 years ago

@bernardolk are you sure that the following default values are empty list? I suspect it because of all the unspecified string values. Just asking to be sure. image

bernardolk commented 2 years ago

Sorry, looking at it again I think we don't have an empty list by default but you can use oauth2_providers = []. I would say to first try the URL I sent, then if that doesn't work, try with the empty list in your tfvars. If anything, maybe just config it but use the regular sign up later instead of github social sign in. We are probably going to remove that section from the tutorials/code in the future.