Closed aler9 closed 11 months ago
Patch and project coverage have no change.
Comparison is base (
6f06385
) 62.98% compared to head (bfc93d7
) 62.98%. Report is 6 commits behind head on main.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello, in tests of
connection
there are multiple data race issues linked to the fact that abytes.Buffer
is written and read by two routines in parallel.Current code is more or less this one:
dataReader1.Write()
is called concurrently withdataReader1.String()
, resulting in the data race.This patch fixes the issue by replacing the
WaitGroup
with two channels that allow to wait on two distinct steps, whetherDial()
has returned and whether the routine has returned:This patch also removes
serverWg.Done()
beforeListenAndServe()
since it's totally useless sinceListenAndServe()
doesn't return until server is shutted down.