datarhei / gosrt

Implementation of the SRT protocol in pure Go
https://datarhei.com
MIT License
114 stars 17 forks source link

Request: Make some packages non internal or expose some needed methods #50

Closed 0xVasconcelos closed 6 months ago

0xVasconcelos commented 7 months ago

Hey!

I'm trying to implement my own PubSub logic(like destroy all subscribers when a publisher disconnects, etc) and the problem is some important packages like packet.Packet are internal and the readPacket/writePackage methods are also internal, with that I would have to copy too many files to implement my logic. It makes sense?

Thanks!

ioppermann commented 6 months ago

Yes that makes sense. These packages are currently internal in order to have smaller API surface. Now that there seems to be some demand, it makes sense to open it up more.

ioppermann commented 6 months ago

All the internal packages are now public.