search

datarobot-community / custom-models

Various DataRobot MLOps examples
Apache License 2.0
27 stars 55 forks source link

Fix the errors in the DRUM introduction notebook linked from "Introducing DRUM" tutorial #5

Closed aslisabanci closed 3 years ago

aslisabanci commented 3 years ago

Hello DataRobot! I have a few fixes for the notebook that's linked from the Introducing DRUM tutorial.

I implemented the changes after trying to follow the tutorial and encountering some errors. I made sure that my changes fixes the cells by running the notebook on Google Colab.

In addition, the tutorial post should be changed to reflect the structural changes in your custom_models repo: The link in the sentence that says "You can test out this workflow by using the code and Jupyter notebook provided here.” is broken. It should point to the correct link.

Happy to communicate under this PR and hear your thoughts, cheers!

aslisabanci commented 3 years ago

Hi @timsetsfire @TheoPetropoulos, I couldn't assign reviewers for my PR and Github didn't do it automatically either. So I wanted to ping you explicitly. Thank you in advance for reviewing my changes, I hope you're happy with them too :)

TheoPetropoulos commented 3 years ago

Closing this as it happened on -wip