datarockets / mona

Mona is a bot that cares about datarockets
9 stars 1 forks source link

Code in Mona is not the best #68

Open nikitasakau opened 4 years ago

nikitasakau commented 4 years ago
lazycoder9 commented 4 years ago

I don't like module.exports and require in code. I prefer to use import/export syntax. I suggest that we can use latest node on heroku to use this syntax. I can make some investigation if it is possible to use latest node in heroku

lazycoder9 commented 4 years ago

use the engines section of your package.json to specify the version of Node.js to use on Heroku. Drop the ā€˜vā€™ to save only the version number:

{
"name": "myapp",
"description": "a really cool app",
"version": "1.0.0",
"engines": {
"node": "12.13.0"
}
}
lazycoder9 commented 4 years ago

I was able to use import and export in code with Node v13.2 locally

lazycoder9 commented 4 years ago

@npupko @nikitasakov what do you think about setting up Github actions? Sounds reasonable if you want to set up linter too

npupko commented 4 years ago

@lazycoder9 Is it (setup) faster than other CI services? How much time will we need to enable it from scratch? Didn't work with it before.

lazycoder9 commented 4 years ago

@npupko it took me about 30 minutes to learn about it and 5 minutes to implement it in docker_benchmark repo šŸ˜„

npupko commented 4 years ago

@lazycoder9 This is what we need then:)

AleksSenkou commented 4 years ago

Gyus, I'd suggest keeping a checklist in issue's description to know what is left, easier to manage

All of you should have access to edit the description šŸ˜‰

npupko commented 4 years ago

Dudes, how about using yarn instead of npm?

lazycoder9 commented 4 years ago

@npupko @nikitasakov Also, I want to move from mocha to jest. Thoughts?

npupko commented 4 years ago

@lazycoder9 Mocks out of the box and rspec-similar syntax. I like it. But is it worth the time?

lazycoder9 commented 4 years ago

@npupko refreshed my knowledge about jest yesterday and I don't think that it is worth our effort currently to move to jest