search

datarockets / rails-views

MIT License
7 stars 0 forks source link

When I develop the gem, I'd like to be confident in code I add, so I'd like tests to help me with it #12

Open AleksSenkou opened 5 years ago

AleksSenkou commented 5 years ago

Tests for all features in rails views, not cells

DDKatch commented 5 years ago

@roman-dubrovsky including these helpers breaks tests executing, can we remove them from codebase because in real app we have access to methods from these helpers?

DDKatch commented 5 years ago 
    include AbstractController::Helpers
    include ActionDispatch::Http::Cache::Request
    include ActionView::RecordIdentifier
AleksSenkou commented 5 years ago

We can run 2-4 hours investigation raid here in order to understand whether we need to include those modules:

1) allocate rails-views' path in gemfile to local gem 2) change gem locally and restart rails server after it 3) check do we need to run bundle install here ^ (not sure about gem caching)

Going with that ^ we can check the availability of helper methods without including those modules

AleksSenkou commented 5 years ago

@DDKatch let's move a discussion for helper modules inclusion to separate issue. This one is for tests coverage 😉

DDKatch commented 5 years ago

@AleksSenkou got it, I'll create separate one for that