search

datarockets / rails-views

MIT License
7 stars 0 forks source link

When I develop the gem I'd be sure that every helper is really important #17

Open DDKatch opened 5 years ago

DDKatch commented 5 years ago

discussion from #12 issue:

Dan

@roman-dubrovsky including these helpers breaks tests executing, can we remove them from codebase because in real app we have access to methods from these helpers?

    include AbstractController::Helpers
    include ActionDispatch::Http::Cache::Request
    include ActionView::RecordIdentifier

Aleks

We can run 2-4 hours investigation raid here in order to understand whether we need to include those modules:

  1. allocate rails-views' path in gemfile to local gem
  2. change gem locally and restart rails server after it
  3. check do we need to run bundle install here ^ (not sure about gem caching)

Going with that ^ we can check the availability of helper methods without including those modules