Open AleksSenkou opened 7 years ago
How often we do write admin panel for api app on rails? I think we should not remove rails-coffee, sass-rails, jquery-rails and others from gemfile.
@MProG we don't need it at all. it's front part of work, and we use react/redux etc. front tools for that but I'm not sure // @roman-dubrovsky @Proghat
@AleksSenkou React for admin panel??? This is not rationally. We can write simple admin panel on rails very fast and very cheap for customers.
@MProG looks reasonable to use react admin panel instead of rails check https://github.com/marmelab/react-admin please
@AleksSenkou I think database_cleaner is useful for testing. Why gem 'pg', '~> 0.18', why not 0.17 or other version. I think base gem 'pg' is enough. And same question about capistrano gem
@AleksSenkou About react admin https://pp.vk.me/c618128/v618128952/1d0eb/wQ3EX2ci2Wk.jpg
@MProG can you please provide useful example of database_cleaner
with code. Maybe I'm loosing something(we don't use it for Vital api)
@AleksSenkou In diffrent tests we can write some information on db. And this situations can results of work other tests is incorrect. If you test work with db you should call DatabaseCleane.clean in my opinion.
@MProG
Why gem 'pg', '~> 0.18', why not 0.17 or other version. I think base gem 'pg' is enough and And same question about capistrano gem
we may have conflicts after bundle update without specifying gem versions
@MProG
In diffrent tests we can write some information on db we have many tests with real db entries and we don't use
database_cleaner
check vital
repo for examples
@AleksSenkou I don't use byebug before but i wrote description and i think this is interesting gem.
Main Idea
Changes
[x] Remove
sass-rails
[x] Remove
uglifier
[x] Remove
coffee-rails
[x] Remove
jquery-rails
[x] Remove
turbolinks
[x] Remove
tzinfo-data
[x] Remove
'jbuilder', '~> 2.4'
, because2.5
is already included in Gemfile[x] Remove
rails_layout
[x] Remove
pry-rescue
[x] Remove
spring-commands-rspec
[x] Change
gem 'rubocop'
togem 'rubocop', require: false
[x] Change
gem 'capistrano', '~> 3.0.1'
to3.6.x
version[x] Remove
capistrano-bundler
[x] Add
gem 'rack-cors', require: 'rack/cors'
. Should be added by default +cors.rb
initializer[x] No need in
ruby '2.3.1'
. It's already specified in.ruby-version
file[x] Let's add
pg
gem specification, for examplegem 'pg', '~> 0.18'
[ ] Let's not have duplicated
:development
groups[x] Gems should be installed into
vendor/bundle
folder, so usebundle install --path vendor/bundle
instead ofbundle install
[x] Let's use new hash style, example
gem 'simplecov', require: false
instead ofgem 'simplecov', :require=>false
Example
Rails API Gemfile
P.S. Ping me if you are not agree, or have better idea.