search

datarootsio / skeleton-pyspark

A best-practices first project template that allows you to get started on a new pyspark project
MIT License
13 stars 4 forks source link

Feature/change argparse to typer #4

Closed vikramaditya91 closed 3 years ago

vikramaditya91 commented 3 years ago

Change from argparse to typer inspired by @murilo-cunha's Might Python session. Significantly reduces code without loss of functionality.

Note that the make submit will not work if your pyspark-env does not have the typer module. It will however work with make submit_with_dep once this is merged into this branch

codecov[bot] commented 3 years ago

Codecov Report

Merging #4 (fa29d2a) into main (b2c746d) will increase coverage by 37.37%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
+ Coverage   41.57%   78.94%   +37.37%     
===========================================
  Files           6        6               
  Lines          89       76       -13     
===========================================
+ Hits           37       60       +23     
+ Misses         52       16       -36
Impacted Files Coverage Δ
src/jobs/utils/general.py 100.00% <ø> (+37.50%) :arrow_up:
src/jobs/main.py 95.83% <100.00%> (+95.83%) :arrow_up:
src/jobs/load.py 50.00% <0.00%> (+50.00%) :arrow_up:
src/jobs/extract.py 66.66% <0.00%> (+66.66%) :arrow_up: