datarootsio / terraform-aws-ecs-dagster

A terraform module that deploys Dagster to AWS, using ECS.
MIT License
30 stars 14 forks source link

Dagster daemon #5

Closed PaoloDataroots closed 3 years ago

PaoloDataroots commented 3 years ago

Working modules with tests and documentation

nicogelders commented 3 years ago

dont forget to remove the .idea folder

nicogelders commented 3 years ago

make sure you adhere to this https://www.terraform.io/docs/language/modules/develop/structure.html

nicogelders commented 3 years ago

rename the 'dagster_init_files' => 'templates' or at least put it in the 'templates folder'

nicogelders commented 3 years ago

copy the "make" file from my module to yours https://github.com/datarootsio/terraform-aws-ecs-airflow/blob/main/Makefile

nicogelders commented 3 years ago

Make sure it has a LICENSE

nicogelders commented 3 years ago

Also there is no .gitignore, copy this from my module

nicogelders commented 3 years ago

you also need to add a release pipeline look at this https://github.com/datarootsio/terraform-aws-ecs-airflow/blob/main/.github/workflows/terraform-master.yml

nicogelders commented 3 years ago

these are the requirements for being to publish to the tf registery https://www.terraform.io/docs/registry/modules/publish.html also adhere to these