Open devdnhee opened 2 years ago
Code is indeed very readable. Issues are really the same as in Dorian's review:
def train_evaluate(params)
def objective(trial)
is only defined once.objective
name, as it is the same as the code examples on the optuna website.
Code is in general very readable. From just validating your code I could understand everything. I've got a few recommendations:
N_TRIALS
assignment above in the same cell as where you provide the general overview.train_evaluate
andobjective
functions are mostly duplicates of each other. As I understood the codetrain_evaluate
is the same everywhere so only keep one, and the only difference in theobjective
functions is when you check if pruning is enabled. Can't you generalize that into one function instead of copy pasting?objective
to reflect thatstudy3
->study_cmaes