resource requests need to be set in chart values

datasci-osu / dsosuk8s

DataScience@OregonState

2 stars 1 forks source link

resource requests need to be set in chart values #27

Closed oneilsh closed 4 years ago

oneilsh commented 4 years ago

currently they are getting set from environment variables straight to the hub because of a rancher UI/helm chart conflict (rancher passes string type, even for "float" UI types, but the chart needs real float, though I could have sworn it didn't in the past)

however, the user placeholders also read their resource requests from the chart, so they need to be set there

oneilsh commented 4 years ago

fixed in https://github.com/oneilsh/dsosuk8s/commit/7b281967a29b1e156143d91c97262d4f6d791ca3 or therabouts - needed to fork the chart's configmap