61 never open guidance - Githubissues

datasciencecampus / coding-in-the-open

A compendium of open-source guidance which aims to share the benefits, risks and a summarised strategy for open-source coding.

https://datasciencecampus.github.io/coding-in-the-open/

MIT License

8 stars 0 forks source link

61 never open guidance #70

Closed r-leyshon closed 9 months ago

r-leyshon commented 10 months ago

Description/Contribution Summary

Fixes #61

Motivation and Context

Guidance has now incorporated feedback from ONS FoI team & DSC colleagues in Email chain.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Accessibility

No errors, one known alert to tolerate - A link to a PDF document is present.

Advice for reviewer

Checklist:

[X] I have read the CONTRIBUTING.md guidance for raising pull requests
[X] I have followed the intended structure of this project
[X] I have performed a self-review
[X] This pull-request meets the accessibility guidance provided in the contributing guidance.

Additional comments

r-leyshon commented 9 months ago

@NicciPotts @ethan-moss @TSGreen Hi all, I just resolved a small merge conflict in the qmd YAML. Does anyone have a couple of hours to review this? Would need draft checking for typos etc and some more opinionated feedback on language used and points made would be welcome, but not required.

NicciPotts commented 9 months ago

@NicciPotts @ethan-moss @TSGreen Hi all, I just resolved a small merge conflict in the qmd YAML. Does anyone have a couple of hours to review this? Would need draft checking for typos etc and some more opinionated feedback on language used and points made would be welcome, but not required.

Hi @r-leyshon I've got a really short week this week (this afternoon and tomorrow) but if I get my model running tomorrow I should be able to give this a look. IF

r-leyshon commented 9 months ago

Some good catches in that latest commit @TSGreen . I don't know what's going on with the referencing syntax, but I find sometimes it accepts some text@ref_with_no_space and on other occasions trying to do that completely breaks all references in the document. I can see you must have encountered this problem when locally renderring. Possibly worth raiseing a bug report on the quarto repo if only I could reproduce the difference.