datasciencecampus / pygrams

Extracts key terminology (n-grams) from any large collection of documents (>1000) and forecasts emergence

https://datasciencecampus.github.io/pygrams

Other

63 stars 23 forks source link

337 stop n #341

Closed thanasions closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #341 into develop will increase coverage by 0.01%. The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
+ Coverage    54.42%   54.44%   +0.01%     
===========================================
  Files           42       42              
  Lines         3456     3453       -3     
===========================================
- Hits          1881     1880       -1     
+ Misses        1575     1573       -2

IanGrimstead commented 5 years ago

If the test test_embeddings_filter_binary returns all zeros, it's a bogus test alas as its missed the data (allegedly) - can you mod the terms so we get at least something non-zero? Otherwise it'll be very easy to accidentally pass that test...