180 cleanup for 195 - Githubissues

CBROWN-ONS commented 8 months ago

Description

This issue handles points 3, 4, 5, 6 from #180

Does not fully fix any issues, only partially #180 This issue should be marked as closed once #195 is merged.

Motivation and Context

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Test configuration details:

OS: Windows 10
Python version: Python 3.9.16
Java version: N/A
Python management system: MiniConda

Advice for reviewer

Checklist:

[x] My code follows the intended structure of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Additional comments

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.18%. Comparing base (7bb4863) to head (4886a42).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #254 +/- ## ======================================= Coverage 98.17% 98.18% ======================================= Files 21 21 Lines 1915 1924 +9 ======================================= + Hits 1880 1889 +9 Misses 35 35 ``` | [Flag](https://app.codecov.io/gh/datasciencecampus/transport-network-performance/pull/254/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datasciencecampus) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/datasciencecampus/transport-network-performance/pull/254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datasciencecampus) | `98.18% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=datasciencecampus#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.