datascijedi / website

https://datascijedi.org
Creative Commons Attribution Share Alike 4.0 International
6 stars 2 forks source link

Add Netlify deploy workflow #61

Closed ravicodelabs closed 1 year ago

ravicodelabs commented 1 year ago

Hi All - this PR contains a workflow to deploy the new website to Netlify. A few updates will be needed for making it live, e.g. using the main branch in the GitHub workflow rather than netlify-deploy-prep, but otherwise is ready and available here for review.

At a high-level: The workflow will deploy from a source branch (e.g. main) to a deploy branch (e.g. main-build), then push to the Netlify instance. The workflow also will also create deploy previews for pull requests to the main branch and then insert the deploy preview link as a comment on the pull request.

mine-cetinkaya-rundel commented 1 year ago

Any idea why the deploy preview was skipped?

ravicodelabs commented 1 year ago

Hi @mine-cetinkaya-rundel - yes, currently "Netlify Production Deploy" and "Netlify Deploy Preview" are mutually exclusive jobs in the "Website Deploy" workflow. (edit: refactored into two separate workflows.)

If you want to test out the deploy preview now, you can do so by opening a pull request against the netlify-deploy-prep branch (once we launch, a PR against the main branch will trigger the deploy preview).

brtarran commented 1 year ago

@ravimakhija I don't have any experience with Netlify deployments, so I'm afraid I don't have anything constructive to contribute by way of review. Apologies.

ravicodelabs commented 1 year ago

No worries @fatso-jetson, I also just wanted to keep you in the loop with these coming changes. Thanks for the note!

ravicodelabs commented 1 year ago

Update: The two workflow jobs have been refactored into two separate workflows, "Production Deploy" and "Deploy Preview", to make it easier/quicker to see which job has run from the GitHub Actions UI.

github-actions[bot] commented 1 year ago

Deploy preview: https://6409ee19fff70c142b92f4c8--datascijedi.netlify.app