search

datascijedi / website

https://datascijedi.org
Creative Commons Attribution Share Alike 4.0 International
6 stars 2 forks source link

Modify GitHub workflows for Netlify integration #73

Closed ravicodelabs closed 1 year ago

ravicodelabs commented 1 year ago

Since we are planning to If we switch to use the Netlify deployment integration, we don't need most of the GitHub workflows anymore. Hence, this PR prepares the workflow changes.

For now, I have kept one GitHub workflow that also pushes the latest build from branch main to branch main-build. Open to others' thoughts on the utility of this, but I kept it since it still provides the advantage of easily viewing the latest build files on GitHub.

netlify[bot] commented 1 year ago

Deploy Preview for datascijedi failed.

Name Link
Latest commit f529482f5a87b2043327427528b47bba5889cdfb
Latest deploy log https://app.netlify.com/sites/datascijedi/deploys/641c17ec8e37d600095c079d
ravicodelabs commented 1 year ago

Merging this in to try the Netlify deployment integration out. (The failed deploy preview in this PR is because this PR is needed for the checks to pass.)

It should be noted that as of this time, the build happens twice, once from the GitHub workflow and once from the Netlify-Quarto publish plugin. The latter is what will be used for the actual deploy previews and deploys.

The GitHub workflow is only used to build and push to main-build, providing a convenient way of viewing the latest build files on GitHub. However, it's possible that there could be small differences in the builds, so the deploy previews should be taken as more representative of what actual deploys (once we're deploying to Netlify) will look like.

More details on the Netlify integration setup can be found on the Quarto docs here.