search

datascijedi / website

https://datascijedi.org
Creative Commons Attribution Share Alike 4.0 International
5 stars 2 forks source link

Remove unused sidebar definition #74

Closed ravicodelabs closed 1 year ago

ravicodelabs commented 1 year ago

It looks like the sidebar option in _quarto.yml is no longer used, so removing it.

github-actions[bot] commented 1 year ago

Deploy preview: https://6419b6d1f6424606114b2bac--datascijedi.netlify.app

github-actions[bot] commented 1 year ago

Deploy preview: https://641b02b84ce49111ee0862dc--datascijedi.netlify.app

github-actions[bot] commented 1 year ago

Deploy preview: https://641b0aff29735d17410f457e--datascijedi.netlify.app

github-actions[bot] commented 1 year ago

Deploy preview: https://641b0e953247e8007438b230--datascijedi.netlify.app

brtarran commented 1 year ago

For some reason I don't quite understand, the activities sidebar is now appearing on all pages throughout the site. I haven't seen this behaviour before on other sites I've built, and this doesn't happen on the live site, despite the code being identical (other than the removal of the "About" sidebar section).

Not sure whether this is a bug in the deploy preview as I can't see anything obviously wrong in the _quarto.yml code. We could fix the issue by setting sidebar: false on all pages other than the Activities.

ravicodelabs commented 1 year ago

A dummy sidebar workaround (added in the last commit) seems to provide the behavior we want, e.g. only have a sidebar active on the Activities page currently. This avoids, I think, the need to specify sidebar: false on every page that we don't want the sidebar to show up on.

It seems the strange behavior was caused due to the way Quarto inherits sidebars. From the docs:

"A page that doesn’t appear in any sidebar will inherit and display the first sidebar- you can prevent the sidebar from showing on a page by setting sidebar: false in it’s front matter."

Source: https://quarto.org/docs/websites/website-navigation.html#hybrid-navigation

Finally, I think the about sidebar we had before was effectively doing the job of a dummy sidebar, so I just made that more explicit in the last commit.