search

datascijedi / website

https://datascijedi.org
Creative Commons Attribution Share Alike 4.0 International
5 stars 2 forks source link

Use a workaround to fix the missing footer border #79

Closed ravicodelabs closed 1 year ago

ravicodelabs commented 1 year ago

Addresses issue #78.

Using a floating sidebar in Quarto sets the floating class on the body element, which in turn causes bootstrap to not apply border-top to nav-footer, causing the footer border not to appear on the "Activities" page.

This workaround uses custom css to make the footer border always appear.

This is probably a Quarto bug. It's also worth noting, we have other experienced other quirky side bar behavior in PR #74 and PR #23.

netlify[bot] commented 1 year ago

Deploy Preview for datascijedi ready!

Name Link
Latest commit 7023e17a937987156d7667ed403fd211da9b6ab7
Latest deploy log https://app.netlify.com/sites/datascijedi/deploys/6421ffa86fbd190007452cae
Deploy Preview https://deploy-preview-79--datascijedi.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ravicodelabs commented 1 year ago

For some reason the earlier build failed, please ignore the last two commits that revert and add the new change back in.

ravicodelabs commented 1 year ago

Filed an issue with Quarto for the potential bug: https://github.com/quarto-dev/quarto-cli/issues/4971