Closed sabas closed 8 years ago
@sabas awesome - please start packaging :-)
This is the terminal code list
https://github.com/PHPEdifact/smdg-master-terminal-facilities-list
@zelima can you review.
@sabas you will need to post validation and preview links as per http://data.okfn.org/doc/core-data-curators#4-publishing
@sabas data looks very good. Great job! Just a little things to consider:
Company Name
instead of CompanyName
yyyy-mm-dd
as format For date types.@zelima thanks, ok changed it. I was also wondering if the geopoint type is supported, in case I can convert the Latitude and Longitude columns
(sorry to interrupt)
@sabas This guide may help you figuring details we usually look around here: http://datapatterns.org/core-guides/core-data-curators/
The website is incomplete and being subject to changes often, but hopefully that will help.
@sabas We've lost table for data.
The reason behind this is the "/" symbol in the "UN/LOCODE"
field name.
The way to fix this is, to separate it with space or do not separate it at all.
Fixed. I also moved the coordinates in a single column with geopoint type
Great, looks good to me, @rgrp any comment about README.md?
@sabas great - could we add a LICENSE
section to README and perhaps a DATA
section. @zelima you know the general outline on the README so I'll let you lead here.
What this is Where it comes from
Restructured like this
List mantained by the SMDG Secretariat to specify the port terminal facilities in UN/EDIFACT messages. The list is directly linked with the UN/LOCODE codelist (see data package)
Example segment where the main location is RULED (UN/LOCODE for Saint Petersburg, Russia) and the facility is PLP (SMDG code for Petrolesport).
LOC+11+RULED:139:6+PLP:72:306
All data is licensed under the Creative Commons 4.0 Attribution License. You may need to attribute the specific code to the SMDG Secretariat.
@sabas Nice, looks fine to me. Could you please update actual README.md in your repository and paste validation and preview link one last time. @rgrp think we are ready to start publishing process.
Done and valid
Following this steps, @sabas needs to transfer ownership to proceed. But first you must become organization member.
@rgrp since I am Team maintainer
of curators team, I can only add users who are already members of organization. We would need to add @sabas as an organization member (I don't have access right for this)
I can't add as an organization member, I think. If this is an urgency, I can clone the repository and just push it upstream, without taking any credit away from @sabas. Still, I think we can wait!
That would be great, thanks @gsilvapt
It is up to @sabas and @rgrp then :+1:
@zelima you are now an owner so you can add @sabas. @pdehaye would you like to guide @zelima in what he needs to do so he knows for the future and can also help with managing curator work :-)
@sabas I've sent you invitation. You can transfer ownership once you accept it.. Please notify here so I could publish data
Great! The dataset has landed here: http://data.okfn.org/data/core/smdg-master-terminal-facilities-list Good job @sabas
Thanks! In these days the list was updated with some request I made to the secretariat, I'll fork and update
@rgrp @sabas we can close this one, right?
Yes, the other lists are less used I think...
http://smdg.org/index.php/smdg-code-lists/
Codes used in maritime industry, mantained as excel files.
I could package these.