datasets / country-codes

Comprehensive country code information, including ISO 3166 codes, ITU dialing codes, ISO 4217 currency codes, and many others
https://datahub.io/core/country-codes
885 stars 575 forks source link

Missing 3 country codes #66

Open lesnet opened 6 years ago

lesnet commented 6 years ago

Grabbed the json version of the ISO 3116-1 Alpha-2 country code list from: https://datahub.io/core/country-codes

I was comparing it to the ITU E.164 data set, and your dataset appears to be missing 3 countries.

AC - Ascention Island

http://www.itu.int/oth/T02020000AF/en ITU Country Code +247

TA - Tristan da Cunha

http://www.itu.int/oth/T02020000AF/en ITU Country Code +290

It shares the +290 code with ISO 3116-1 "SH" - SAINT HELENA, ASCENSION AND TRISTAN DA CUNHA

XK - Kosovo (Temporary code assigned)

http://www.itu.int/oth/T020200008D/en ITU Country Code +383

ewheeler commented 6 years ago

Thanks @lesnet

There is only one ISO 3116 code issued for the three territories: https://www.iso.org/obp/ui/#iso:code:3166:SH

So these are listed in a single row here: https://github.com/datasets/country-codes/blob/master/data/country-codes.csv#L437

Unfortunately ITU does not publish a machine-readable file of all dialing codes (or at least I haven't found one!), but would be happy to pull from a better source if one is available!

lesnet commented 6 years ago

Hi Evan.

I've been working on aggregating, validating and producing my own country code/dial code list for a few days now as part of new screening/filtering logic we are implementing to validate phone numbers.

It's a combination of the php-port of googles libphonenumber, public domain country/region lists, iso csv's, and some proprietary industry data we subscribe to as a telecom carrier.

There always seems to be a handful of discrepancies, errors or omissions on pretty much every data source I find, which is to be expected.  So I've been parsing everything I can find against everything else I can find, and finding the odd-balls.

For example, one industry data source uses AN for Antigua when most use AG.  BV for British Virgin Islands vs VG, RT for Montserrat vs MS.. the list goes on.

I guess a lot it has to do with the viewpoint/industry that you are in.  From my perspective it's from a telecom/ITU stand point.

Anyway, if you'd like I can pass along the summarized output that I have come up with.

Les

On 2018-08-06 03:40 PM, Evan Wheeler wrote:

Thanks @lesnet https://github.com/lesnet

There is only one ISO 3116 code issued for the three territories: https://www.iso.org/obp/ui/#iso:code:3166:SH

So these are listed in a single row here: https://github.com/datasets/country-codes/blob/master/data/country-codes.csv#L437

Unfortunately ITU does not publish a machine-readable file of all dialing codes (or at least I haven't found one!), but would be happy to pull from a better source if one is available!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/datasets/country-codes/issues/66#issuecomment-410846157, or mute the thread https://github.com/notifications/unsubscribe-auth/AoM0GLu-JW83YeVcO5zs6boSoy-_hEvbks5uOKnagaJpZM4Vw5F9.

-- Leslie Bester LES.NET (1996) INC. +1.204.944.0009 Ext:2