search

datasets / covid-19

Novel Coronavirus 2019 time series data on cases
https://datahub.io/core/covid-19
1.16k stars 606 forks source link

Add plyvel dependency #38

Closed manjeetbhati closed 4 years ago

manjeetbhati commented 4 years ago

there's a dependency on python module plyvel 1.2.0 which is not listed in requirements.

anuveyatsu commented 4 years ago

@manjeetbhatia which python version are you using? Please, see github actions here and it works ok with the current requirements.txt - https://github.com/datasets/covid-19/blob/master/.github/workflows/actions.yml#L6-L17

manjeetbhati commented 4 years ago

@anuveyatsu I used 3.6.3 and had issues. documents says 3.6 not the minor so I suppose it should work for all 3.6..* ? https://github.com/datasets/covid-19#preparation .

anuveyatsu commented 4 years ago

@manjeetbhatia I'm running v3.6.2 in the virtual env and there is no problem with the dependencies.

manjeetbhati commented 4 years ago

@anuveyatsu here's the trace python3 process.py Traceback (most recent call last): File "/usr/local/lib/python3.6/site-packages/kvfile/kvfile.py", line 5, in import plyvel as DB_ENGINE ModuleNotFoundError: No module named 'plyvel'

here's python version ~/covid/covid-19$ python3 Python 3.6.3 (default, Mar 24 2020, 17:09:42)

but after installing plyvel==1.2.0 this works fine.

anuveyatsu commented 4 years ago

Hi @manjeetbhatia I totally understand it, however, we can't merge this PR since it isn't reproducible on other machines. I believe this issue is your environment (python distribution etc.) specific.