Some countries are missing

datasets / geo-countries

Country polygons as GeoJSON in a datapackage

https://datahub.io/core/geo-countries

455 stars 119 forks source link

Some countries are missing #1

Open lexman opened 8 years ago

lexman commented 8 years ago

As stated previously in https://github.com/datasets/geo-boundaries-world-110m/issues/1, some countries are missing.

There are not present in the source data from NaturalEarth, likely because they are too small for the scale (1:110m). I see 4 options :

ignore them, because If anyone wants to use this map, it is at high scale, so they wouldn't appear anyway
Add them manually, maybe as a point in order to keep perfect junction beetween countries (for example, Andorra is between France and Spain)
use a source at smaller scale, wich will result in a bigger json file
use a source at smaller scale, and rescale it, but we'll lose perfect junctions between boundaries

Any idea anyone ?

jalbertbowden commented 8 years ago

i like the first option. i also appreciate your initiative here. after looking into this last year, i came to a wall.

pwalsh commented 8 years ago

Those countries are available "Admin 0 - Countries" available here:

http://www.naturalearthdata.com/downloads/10m-cultural-vectors/

If this is the canonical data package for geo/country data, I don't see how we can leave out some internationally recognised countries, so perhaps this zip is a better source from Natural Earth than the one currently being used.

Also for ref. https://github.com/openspending/cosmopolitan/issues/25

lexman commented 8 years ago

So @pwalsh you're heading towards solution 3 or 4. The zip you are speaking about is 200MB instead of 1MB. Should we simplify the geographic shapes to reduce size (but as the simplification is independant on each country, we'll have no guaranty that the counries won't overlap, oce simplified) or keep it big (estimaton 100MB) ?

pwalsh commented 8 years ago

@lexman I don't know, but this is an interesting case for DataPackage, as our use case in Cosmopolitan is to generate an API with decent resolution of polygons per country, I'm not that interested in:

a) the size of the source data package b) a source lossy to the point of removing countries

So, obviously, a compromise would need to be found, and the compromise is dependant on the expected use cases for the data package in question. My personal though would be that we want, at least, higher resolution than we currently have.

lexman commented 8 years ago

I've updated data with the more accurate source. Now there are 255 countries in the package. Good news, the geojson is only 25MB, wich seems reasonable to me.

@pwalsh tell me how it goes with the updated data. I'll be happy to know if it solves your issue...

lexman commented 8 years ago

@pwalsh how did it go ? Can I close this issue ?

jalbertbowden commented 5 years ago

coming here from this issue; countries missing being:
-Hawaii -Republic of Moldova - is Moldova -Tahiti -Zanzibar

Hawaii being listed, I'm not sure if that is a missing country or the US state.
Moldova is there, not sure if that is correct. going to investigate before reporting back.

Simobain commented 5 years ago

What about Kosovo ? The city is present however we can't find its ISO_A3 code it should be XKX Source : https://countrycode.org/