search

datasets / publicbodies

A database of public bodies such as government departments, ministries etc.
http://publicbodies.org
MIT License
63 stars 26 forks source link

Automate deployment of website / continuous delivery #115

Closed augusto-herrmann closed 3 years ago

augusto-herrmann commented 3 years ago

Whenever new commits are merged to master, if all tests pass, the code should probably be automatically deployed to the production environment.

So far we only have data tests, but once we have some test coverage on the code as well, it should be a step toward having continuous delivery.

augusto-herrmann commented 3 years ago

I cannot configure automatic deployment to Heroku from this repository. The okfn organisation does not appear among the options available to select, even after I've authorized Heroku on Github's OAuth:

heroku-deploy

I think the reason is probably because I'm not a member of the okfn organisation, but rather an outside collaborator:

outside-collaborator

@rufuspollock or @todrobbins can you help?

todrobbins commented 3 years ago

@augusto-herrmann I think you're right that it has to do with OKFN membership. Unfortunately, I'm only a member and cannot add you.

augusto-herrmann commented 3 years ago

Thanks @todrobbins for looking it up. So unless you have time to set up the deployment of this repo yourself, I guess we're going to have to wait until @rufuspollock can add me as a member.

todrobbins commented 3 years ago

Screen Shot 2021-09-08 at 11 30 24 AM

I connected the repo and enabled automatic deploys and also just kicked off a manual deploy. Looks like it's working just right:

Screen Shot 2021-09-08 at 11 32 30 AM

augusto-herrmann commented 3 years ago

Yay, thank you @todrobbins! :tada:

Now I can finally try to merge PR #111. Once it is merged, though, I'm not sure if deployment to Heroku will happen via their direct Node.js support or building a Docker container, so I still may need to make some adjustments in Heroku. Let's hope my permissions are enough to do it.