search

datasets / publicbodies

A database of public bodies such as government departments, ministries etc.
http://publicbodies.org
MIT License
64 stars 28 forks source link

fixing the sorted Swedish contact data #70

Closed mattiasaxell closed 8 years ago

mattiasaxell commented 8 years ago

Noticed I had configured some columns incorrectly. Now updated with added customised columns for Sweden and data sorted correctly.

todrobbins commented 8 years ago

@mattiasaxell it looks like you're missing id values, which are the URL slugs. See for instance: https://github.com/okfn/publicbodies/blob/master/data/br.csv#L1

mattiasaxell commented 8 years ago

@todrobbins you're totally right! I'm aware of that issue, I need help to automatically combine "{jurisdiction-code}/{unique-id-for-body-within-jurisdiction}". Perhaps with a LibreOffice-formula? I'm a newb when it comes to .csv and working with raw data.

todrobbins commented 8 years ago

Let me see if I can help. I'd really recommend we resolve that before merging. 🛠

mattiasaxell commented 8 years ago

I agree it should be resolved before merging. Would be great, you're very welcome to help! I couldn't find any guide on how to formatting accordingly to used standard. If you could show documentation on how it's done I would love to learn!

rufuspollock commented 8 years ago

@todrobbins great assistance!

@mattiasaxell great contribution and thank-you for submitting this. I should say that is is ok to have numeric identifiers - though could you explain where the identifiers got generated from?

@todrobbins & @mattiasaxell assuming the numeric ids are good vs something more "slug" like all you would need to do is prefix with swedish 2 digit iso code which is "se" e.g. se/{numeric-id}

I am also cc'ing @augusto-herrmann as he has become informal editor for this dataset!

mattiasaxell commented 8 years ago

@rgrp you're very welcome. Needed to get contact details for Alaveteli/FROIDE FOI platform anyway. :) I mistook the id column as a way to add Swedish organisational number. I changed that in second pull request and created org_id column. There's no source for id so I guess slug should replace it what you currently see in id.

@rgrp I'd be grateful if @todrobbins helps out with creating these slugs, I have no idea how to.

I should also mention that these details are from fall 2015. I have had to e-mail authorities or download authorities by category in bulk to put together to one CSV (until they start pushing to GitHub themselves :smile:). I don't know how to make a nice hack doing it automatically.

rufuspollock commented 8 years ago

@mattiasaxell amazing work.

@todrobbins @augusto-herrmann can you guys take a look here and get this merged in :-)

/cc @danfowler

todrobbins commented 8 years ago

I'm still working on the slugs, but we could merge now and add that later. Thoughts?

mattiasaxell commented 8 years ago

@todrobbins I'm realizing now that I can add embassies, which is a bit difficult, but then make another PR with that fix. Would it be better for your work on slugs? I assume it could make easier to maintain it later.

todrobbins commented 8 years ago

@mattiasaxell I'm going to merge this pull request and let you carry on with adding the embassies while I also work on the slugs. Thanks!

augusto-herrmann commented 8 years ago

Ok, I've added issue #71 to keep track of what still needs to be done. Thanks for the the contribution, @mattiasaxell !