search

datasets / publicbodies

A database of public bodies such as government departments, ministries etc.
http://publicbodies.org
MIT License
63 stars 26 forks source link

fix errors in data for Germany (#95) #96

Closed augusto-herrmann closed 6 years ago

augusto-herrmann commented 6 years ago

It now passes Goodtables validation.

$ goodtables --schema public-body-schema.json data/de.csv
DATASET
=======
{'error-count': 0,
 'preset': 'nested',
 'table-count': 1,
 'time': 0.37,
 'valid': True}

TABLE [1]
=========
{'encoding': 'utf-8',
 'error-count': 0,
 'format': 'csv',
 'headers': ['id',
             'name',
             'abbreviation',
             'other_names',
             'description',
             'classification',
             'parent_id',
             'founding_date',
             'dissolution_date',
             'image',
             'url',
             'jurisdiction_code',
             'email',
             'address',
             'contact',
             'tags',
             'source_url'],
 'row-count': 1004,
 'schema': 'table-schema',
 'scheme': 'file',
 'source': 'data/de.csv',
 'time': 0.367,
 'valid': True}

That should solve #95.

rufuspollock commented 6 years ago

It would be good to state in commits what exactly you are fixing in the errors for Germany :smile:

augusto-herrmann commented 6 years ago

Perhaps in this case I suppose they could fit in a single commit line. Hey, at least I did reference the issue where the errors are described in detail. :wink: