datasets / publicbodies

A database of public bodies such as government departments, ministries etc.
http://publicbodies.org
MIT License
63 stars 26 forks source link

[Great Britain] incorrectly formatted URIs for public bodies #97

Closed augusto-herrmann closed 4 years ago

augusto-herrmann commented 6 years ago

Goodtables detects some problems in British data on data/gb.csv:

$ goodtables --schema public-body-schema.json data/gb.csv
DATASET
=======
{'error-count': 5,
 'preset': 'nested',
 'table-count': 1,
 'time': 1.709,
 'valid': False}

TABLE [1]
=========
{'encoding': 'cp1252',
 'error-count': 5,
 'format': 'csv',
 'headers': ['id',
             'name',
             'abbreviation',
             'other_names',
             'description',
             'classification',
             'parent_id',
             'founding_date',
             'dissolution_date',
             'image',
             'url',
             'jurisdiction_code',
             'email',
             'address',
             'contact',
             'tags',
             'source_url'],
 'row-count': 5363,
 'schema': 'table-schema',
 'scheme': 'file',
 'source': 'data/gb.csv',
 'time': 1.706,
 'valid': False}
---------
[13,11] [type-or-format-error] The value "www.aberdeencity.gov.uk/licensing" in row 13 and column 11 is not type "string" and format "uri"
[221,11] [type-or-format-error] The value "www.dab-vjb.gov.uk" in row 221 and column 11 is not type "string" and format "uri"
[1240,11] [type-or-format-error] The value "www.supplyzone.org.uk" in row 1240 and column 11 is not type "string" and format "uri"
[2277,11] [type-or-format-error] The value "iwac.gov.uk" in row 2277 and column 11 is not type "string" and format "uri"
[5206,11] [type-or-format-error] The value "none" in row 5206 and column 11 is not type "string" and format "uri"

Lines 13. 221. 1240 and 2277 are easily fixable by adding the schema part of the URI (http or https). Line 5206 should just have an empty field for URI instead of the value "none".

augusto-herrmann commented 6 years ago

Aberdeen City Licensing Board

Website no longer works and the URL gives a 404 error. After some searching, found out a new URL for it.

Assessor for Dunbartonshire and Argyll and Bute Valuation Joint Board

URL still works, just add http.

Devon Procurement Services

URL no longer works. After some searching could not find a webpage for the Procurement Services itself, but a page about procurement that has information about the Procurement Services, including contact information and address. I'm using this URL in place of the old one.

Inland Waterways Advisory Council

The body was abolished on 2nd July 2012, according to this page at the Inland Waterways Association, following a public consultation about it. The URI field was then emptied and inserted the dissolution date into the appropriate field.

augusto-herrmann commented 6 years ago

@rufuspollock, since you contributed the file data/gb.csv, would you care to take a look at the PR?

augusto-herrmann commented 4 years ago

Issue fixed!